[skill-drift] update(sentry-cloudflare-sdk): document dataCollection option#148
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…option Automated drift-fix run. Co-Authored-By: Claude (claude-sonnet-4-5) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+527
to
+530
| | Old (legacy) | New (v10.54.0+) | | ||
| |--------------|-----------------| | ||
| | `sendDefaultPii: true` | `dataCollection: { cookies: true }` | | ||
| | `sendDefaultPii: false` | `dataCollection: { cookies: false }` (Cloudflare default) | |
There was a problem hiding this comment.
Bug: The documentation suggests an invalid configuration dataCollection: { cookies: false } for disabling cookies. The correct value should be an object like { mode: "off" }.
Severity: MEDIUM
Suggested Fix
Update the migration table to show the correct configuration for disabling cookies. Replace dataCollection: { cookies: false } with dataCollection: { cookies: { mode: "off" } }. Alternatively, clarify that omitting the cookies field also disables cookie collection by default.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-cloudflare-sdk/SKILL.md#L527-L530
Potential issue: The migration table in the documentation incorrectly advises users to
migrate from `sendDefaultPii: false` to `dataCollection: { cookies: false }`. According
to official Sentry SDK documentation, the `cookies` option does not accept a raw boolean
`false` value. The correct way to disable cookie collection is by using an object with a
mode, such as `{ mode: "off" }`. Users following the current documentation might
encounter TypeScript errors, runtime validation errors, or a silent misconfiguration
where their settings are ignored, potentially leading to unintended data collection.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Auto-generated from external SDK content. Review all links and code suggestions before acting on them.
Summary
Updates the Cloudflare SDK skill to document the new
dataCollectionoption introduced in v10.54.0 (PR #21237), which provides granular control over captured data and replaces the legacysendDefaultPiiboolean.Changes
Main Skill (SKILL.md)
dataCollection.cookiesinstead ofsendDefaultPiidataCollectionoptionsdataCollectionentry and markedsendDefaultPiias legacysendDefaultPiitodataCollectionError Monitoring Reference (error-monitoring.md)
dataCollection.cookiesdataCollectionoptionsdataCollectionconfigurationDurable Objects Reference (durable-objects.md)
dataCollection.cookiesKey Points
sendDefaultPiistill works as a transitional optionsendDefaultPiiwill be removed in v11Reviewed PRs
dataCollectionSource PRs
dataCollection