Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@sentry/nextjs": "latest || *",
"@orpc/server": "latest",
"@orpc/client": "latest",
"next": "14.2.35",
"next": "16.1.5",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatched eslint-config-next version after major Next.js upgrade

Low Severity

The next dependency is being upgraded to 16.1.5 but eslint-config-next remains at ^14.2.4 in devDependencies. This creates a 2 major version mismatch between the runtime framework and its linting configuration. While this won't cause runtime failures, it may result in outdated linting rules that don't reflect Next.js 16 patterns and best practices.

Additional Locations (1)

Fix in Cursor Fix in Web

"react": "18.3.1",
"react-dom": "18.3.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade to Next.js 16 breaks the app. The synchronous generateMetadata and headers() API calls are no longer supported and will cause runtime errors.
Severity: CRITICAL

Suggested Fix

Update the application code to be compatible with Next.js 16. Make the generateMetadata() function in src/app/layout.tsx asynchronous. In src/orpc/server.ts, ensure that the headers() function is awaited before its value is used. Also, consider aligning the React version with other Next.js 16 test apps (e.g., to React 19.1.0).

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: dev-packages/e2e-tests/test-applications/nextjs-orpc/package.json#L24

Potential issue: Upgrading Next.js to version 16 introduces breaking API changes that
are not addressed in the `nextjs-orpc` test application. Specifically, the
`generateMetadata()` function in `src/app/layout.tsx` is synchronous, but Next.js 16
requires it to be `async`, which will cause metadata generation to fail. Additionally,
the `headers()` function from `next/headers` is now asynchronous and must be `await`ed.
The synchronous call to it in `src/orpc/server.ts` via `globalThis.$headers = headers;`
will throw a runtime error. These issues will cause the application to fail at runtime.

Did we get this right? 👍 / 👎 to inform future reviews.

"server-only": "^0.0.1"
Expand Down
Loading