chore(deps): bump next from 14.2.35 to 16.1.5 in /dev-packages/e2e-tests/test-applications/nextjs-orpc#19079
Conversation
Bumps [next](https://github.com/vercel/next.js) from 14.2.35 to 16.1.5. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.35...v16.1.5) --- updated-dependencies: - dependency-name: next dependency-version: 16.1.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
| "next": "14.2.35", | ||
| "next": "16.1.5", | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1", |
There was a problem hiding this comment.
Bug: The upgrade to Next.js 16 breaks the app. The synchronous generateMetadata and headers() API calls are no longer supported and will cause runtime errors.
Severity: CRITICAL
Suggested Fix
Update the application code to be compatible with Next.js 16. Make the generateMetadata() function in src/app/layout.tsx asynchronous. In src/orpc/server.ts, ensure that the headers() function is awaited before its value is used. Also, consider aligning the React version with other Next.js 16 test apps (e.g., to React 19.1.0).
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: dev-packages/e2e-tests/test-applications/nextjs-orpc/package.json#L24
Potential issue: Upgrading Next.js to version 16 introduces breaking API changes that
are not addressed in the `nextjs-orpc` test application. Specifically, the
`generateMetadata()` function in `src/app/layout.tsx` is synchronous, but Next.js 16
requires it to be `async`, which will cause metadata generation to fail. Additionally,
the `headers()` function from `next/headers` is now asynchronous and must be `await`ed.
The synchronous call to it in `src/orpc/server.ts` via `globalThis.$headers = headers;`
will throw a runtime error. These issues will cause the application to fail at runtime.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "@orpc/server": "latest", | ||
| "@orpc/client": "latest", | ||
| "next": "14.2.35", | ||
| "next": "16.1.5", |
There was a problem hiding this comment.
Mismatched eslint-config-next version after major Next.js upgrade
Low Severity
The next dependency is being upgraded to 16.1.5 but eslint-config-next remains at ^14.2.4 in devDependencies. This creates a 2 major version mismatch between the runtime framework and its linting configuration. While this won't cause runtime failures, it may result in outdated linting rules that don't reflect Next.js 16 patterns and best practices.
Additional Locations (1)
|
e2e tests are ok to not be updated |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps next from 14.2.35 to 16.1.5.
Release notes
Sourced from next's releases.
... (truncated)
Commits
acba4a6v16.1.5e1d1fc6Add maximum size limit for postponed body parsing (#88175)500ec83fetch(next/image): reduce maximumResponseBody from 300MB to 50MB (#88588)1caaca3feat(next/image)!: addimages.maximumResponseBodyconfig (#88183)522ed84Sync DoS mitigations for React Flight8cad197[backport][cna] Ensure created app is not considered the workspace root in pn...2718661Backport/docs fixes (#89031)5333625Backport/docs fixes 16.1.5 (#88916)60de6c2v16.1.45f75d22backport: Only filter next config if experimental flag is enabled (#88733) (#...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.