-
-
Notifications
You must be signed in to change notification settings - Fork 465
Add Tomcat support in the system test runner and tests to the spring-jakarta sample #4635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try-java into webb/e2e_tests_with_tomcat
Contributor
Performance metrics 🚀
|
adinauer
approved these changes
Aug 13, 2025
Member
adinauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We'll also have to make CI run the tests by adding it to system-tests-backend.yml.
…n the system-test-runner
…try-java into webb/e2e_tests_with_tomcat
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
Increased the
servlet-api-jakartadependency version for compatibility with a supported version of Tomcat: https://tomcat.apache.org/whichversion.htmlAdd
Mainclass and relevant Gradle plugins for thespring-jakartasample so a compatible embedded Tomcat server can be launched with theruntask.Modified and added annotations to the
spring-jakartasample to avoid exceptions when hitting the endpoints served with Tomcat.Copied
PersonSystemTestfrom thespring-boot-jakartasample with the following modifications: set the id path parameter to 11 instead of 1 in the so the same exception is triggered, and removed the check for the presence of a database query span asspring-jakartahas no database interactions.Added the ability to start and stop the embedded Tomcat server through
system-test-runner.py, and ensured the new system tests are run by the script.💡 Motivation and Context
💚 How did you test it?
Ran the
system-test-runner.pyscript with different combinations of arguments and flags.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps