Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Aug 13, 2025

📜 Description

#skip-changelog

  • Increased the servlet-api-jakarta dependency version for compatibility with a supported version of Tomcat: https://tomcat.apache.org/whichversion.html

  • Add Main class and relevant Gradle plugins for the spring-jakarta sample so a compatible embedded Tomcat server can be launched with the run task.

  • Modified and added annotations to the spring-jakarta sample to avoid exceptions when hitting the endpoints served with Tomcat.

  • Copied PersonSystemTest from the spring-boot-jakarta sample with the following modifications: set the id path parameter to 11 instead of 1 in the so the same exception is triggered, and removed the check for the presence of a database query span as spring-jakarta has no database interactions.

  • Added the ability to start and stop the embedded Tomcat server through system-test-runner.py, and ensured the new system tests are run by the script.

💡 Motivation and Context

💚 How did you test it?

Ran the system-test-runner.py script with different combinations of arguments and flags.

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 392.60 ms 428.86 ms 36.26 ms
Size 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: webb/e2e_tests_with_tomcat

Startup times

Revision Plain With Sentry Diff
1bd56dd 407.02 ms 435.42 ms 28.40 ms
8176057 450.50 ms 479.45 ms 28.95 ms

App size

Revision Plain With Sentry Diff
1bd56dd 1.58 MiB 2.10 MiB 530.96 KiB
8176057 1.58 MiB 2.10 MiB 530.95 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We'll also have to make CI run the tests by adding it to system-tests-backend.yml.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@alexander-alderman-webb alexander-alderman-webb merged commit 0a9896b into main Aug 14, 2025
39 of 40 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/e2e_tests_with_tomcat branch August 14, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants