Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Aug 14, 2025

📜 Description

#skip-changelog

Follow up on #4635, with similar changes as the spring sample is analogous to the spring-jakarta sample.

One notable difference is that the Spring Boot 2's BOM pulls in Kotlin and Jackson versions that are incompatible with the ones specified in our version catalogue. I therefore included Kotlin and Jackson BOMs after the Spring Boot one. As a nice side effect spotlessGradleApply started working again on the sample.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.86 ms 466.20 ms 62.34 ms
Size 1.58 MiB 2.10 MiB 532.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7314dbe 437.83 ms 505.64 ms 67.81 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
b750b96 408.98 ms 480.32 ms 71.34 ms
c8125f3 397.65 ms 485.14 ms 87.49 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms

App size

Revision Plain With Sentry Diff
7314dbe 1.58 MiB 2.10 MiB 533.45 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB

Previous results on branch: webb/e2e_tests_spring

Startup times

Revision Plain With Sentry Diff
a5aaad8 426.89 ms 461.90 ms 35.00 ms
2b2b647 390.83 ms 431.83 ms 41.00 ms
5d1948a 417.21 ms 475.94 ms 58.73 ms
c1fc233 357.19 ms 399.57 ms 42.39 ms

App size

Revision Plain With Sentry Diff
a5aaad8 1.58 MiB 2.10 MiB 530.95 KiB
2b2b647 1.58 MiB 2.10 MiB 532.32 KiB
5d1948a 1.58 MiB 2.10 MiB 533.43 KiB
c1fc233 1.58 MiB 2.10 MiB 533.46 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, can we keep JDK 8? I'm worried that we start breaking things for customers who might still be on an old version of JDK.

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

cursor[bot]

This comment was marked as outdated.

@alexander-alderman-webb alexander-alderman-webb merged commit 7ef4278 into main Sep 12, 2025
49 of 51 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/e2e_tests_spring branch September 12, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add E2E tests for Spring

4 participants