Skip to content

Conversation

@adinauer
Copy link
Member

#skip-changelog

📜 Description

SentryIntegrationPackageStorage.addPackage calls have been moved to static / companion object init blocks in #4271

💡 Motivation and Context

No need to call it twice.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9d7449a

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 418.40 ms 460.29 ms 41.90 ms
Size 1.58 MiB 2.22 MiB 654.84 KiB

Previous results on branch: feat/remove-duplicate-add-package-calls

Startup times

Revision Plain With Sentry Diff
492b1c1 384.80 ms 424.71 ms 39.91 ms
0e6c63e 434.11 ms 493.36 ms 59.25 ms
d02b5f0 422.92 ms 462.67 ms 39.76 ms

App size

Revision Plain With Sentry Diff
492b1c1 1.58 MiB 2.22 MiB 654.88 KiB
0e6c63e 1.58 MiB 2.22 MiB 654.89 KiB
d02b5f0 1.58 MiB 2.22 MiB 654.89 KiB

@adinauer adinauer changed the title Check for mixed SDK versions Remove duplicate calls to addPackage Mar 25, 2025
Base automatically changed from feat/crash-on-startup-with-mixed-versions to main March 27, 2025 12:46
@adinauer adinauer merged commit 98fbe0e into main Mar 27, 2025
35 checks passed
@adinauer adinauer deleted the feat/remove-duplicate-add-package-calls branch March 27, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants