-
-
Notifications
You must be signed in to change notification settings - Fork 465
Do not enable Sentry SDK for Android when mixed versions are detected #4271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995f145 | 413.38 ms | 490.31 ms | 76.94 ms |
| d378e33 | 434.77 ms | 485.37 ms | 50.60 ms |
| d0ff1c3 | 445.58 ms | 509.68 ms | 64.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995f145 | 1.58 MiB | 2.21 MiB | 647.55 KiB |
| d378e33 | 1.58 MiB | 2.21 MiB | 647.55 KiB |
| d0ff1c3 | 1.58 MiB | 2.21 MiB | 647.55 KiB |
| .log( | ||
| SentryLevel.ERROR, | ||
| "Not initializing Sentry because mixed SDK versions have been detected."); | ||
| return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in #4277 to cause an exception instead.
romtsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but do you want to remove the calls to addPackage from ctors/registers? I guess at this point they are all redundant
Yeah I can follow up with another PR to remove those. |
|
Removed duplicate calls to |
#skip-changelog
Changelog entry is created in #4277
Parts of this PR are replaced in #4277 too
📜 Description
💡 Motivation and Context
Step 2 of solving #4132
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps