-
Notifications
You must be signed in to change notification settings - Fork 71
feat: reorg of codebase #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
3351f4d to
ec906ff
Compare
|
The current PR only addresses a repo reorg, a few things that are pending for the future is:
Related issues: #281 |
avinash2692
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on the offline code review.
nrfulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (extensive discussion during offline code review).
Closes: #285
Main changes:
As a part of this, I had to remap a lot of imports in tests and docs. Most common remappings are here:
Details
Testing: All passed.
Note: when we cut the release that includes this change, we should force a
0.x.0version change.