Skip to content

Conversation

@psschwei
Copy link
Contributor

@psschwei psschwei commented Jan 9, 2026

Fixes #214

Fixes an issue where user-configured log levels on fancy_logger were being overwritten when MelleaSession was initialized. The fix checks if the logger level is still NOTSET before applying the default level, preserving any level the user set beforehand.

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@mergify
Copy link

mergify bot commented Jan 9, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@nrfulton nrfulton self-requested a review January 13, 2026 17:04
@nrfulton
Copy link
Contributor

Thanks, looks good. We're in code freeze until #310 is merged. That should resolve automatically for this PR. I will merge this some time tomorrow (after #310), or ping you if there are unanticipated merge issues with #310.

@nrfulton
Copy link
Contributor

#310 is now merged, which created conflicts (we moved fancy_logger, I think). Because this PR is from a branch on your repo, it'll be easiest if you resolve the merge conflict and push. Once it's resolved I will run the CICD checks and merge. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MelleaSession sets logging level to debug

2 participants