Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmark/matobj/bench-matobj-creation.g
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ RunMatObjTest := function(desc, filter, ring)
TestCreatingMatrixObj(filter, ring);
end;

RunMatObjTest("GF(2) IsPlistMatrixRep", IsPlistMatrixRep, GF(2));
RunMatObjTest("integer IsPlistMatrixRep", IsPlistMatrixRep, Integers);
RunMatObjTest("rational IsPlistMatrixRep", IsPlistMatrixRep, Rationals);
RunMatObjTest("GF(2) IsRowPlistMatrixRep", IsRowPlistMatrixRep, GF(2));
RunMatObjTest("integer IsRowPlistMatrixRep", IsRowPlistMatrixRep, Integers);
RunMatObjTest("rational IsRowPlistMatrixRep", IsRowPlistMatrixRep, Rationals);

# TODO: other reps
# TODO: other compare with creating plist-of-plist
4 changes: 2 additions & 2 deletions doc/ref/matobj.xml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ section.

One implementation of such matrices is given by the
<Ref Attr="ConstructingFilter" Label="for a matrix object"/> value
<Ref Filt="IsPlistMatrixRep"/>,
<Ref Filt="IsRowPlistMatrixRep"/>,
and any row of these matrices is a vector object in
<Ref Filt="IsPlistVectorRep"/>.
Note that these objects do <E>not</E> lie in <Ref Filt="IsList"/>
Expand Down Expand Up @@ -370,7 +370,7 @@ described in this chapter is supported.

<#Include Label="IsGF2MatrixRep">
<#Include Label="Is8BitMatrixRep">
<#Include Label="IsPlistMatrixRep">
<#Include Label="IsRowPlistMatrixRep">
<#Include Label="IsZmodnZMatrixRep">

</Section>
Expand Down
2 changes: 1 addition & 1 deletion lib/matobj.gi
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ function( basedomain )
## elif IsFinite(basedomain) and IsZmodnZObj(Zero(basedomain)) then
## return IsZmodnZMatrixRep;
fi;
return IsPlistMatrixRep;
return IsRowPlistMatrixRep;
end);


Expand Down
2 changes: 1 addition & 1 deletion lib/matobj1.gd
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ DeclareCategory( "IsVectorObj", IsVector and IsVecOrMatObj and IsRowVectorOrVect
## true
## false
## true
## gap> m:= NewIdentityMatrix( IsPlistMatrixRep, GF(2), 2 );;
## gap> m:= NewIdentityMatrix( IsRowPlistMatrixRep, GF(2), 2 );;
## gap> IsMatrix( m ); IsMatrixObj( m ); IsMatrixOrMatrixObj( m );
## false
## true
Expand Down
2 changes: 1 addition & 1 deletion lib/matobj2.gd
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ DeclareOperation( "IdentityMatrix", [ IsOperation, IsSemiring, IsInt ] );
## <P/>
## <Example><![CDATA[
## gap> x:= X( GF(5) );; pol:= x^3 + x^2 + 2*x + 3;;
## gap> M:= CompanionMatrix( IsPlistMatrixRep, pol, GF(25) );;
## gap> M:= CompanionMatrix( IsRowPlistMatrixRep, pol, GF(25) );;
## gap> Display( M );
## <3x3-matrix over GF(5^2):
## [[ 0*Z(5), 0*Z(5), Z(5) ]
Expand Down
12 changes: 6 additions & 6 deletions lib/matobjplist.gd
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,16 @@ DeclareRepresentation( "IsPlistVectorRep",

#############################################################################
##
## <#GAPDoc Label="IsPlistMatrixRep">
## <#GAPDoc Label="IsRowPlistMatrixRep">
## <ManSection>
## <Filt Name="IsPlistMatrixRep" Arg='obj' Type="Representation"/>
## <Filt Name="IsRowPlistMatrixRep" Arg='obj' Type="Representation"/>
##
## <Description>
## An object <A>obj</A> in <Ref Filt="IsPlistMatrixRep"/> describes
## An object <A>obj</A> in <Ref Filt="IsRowPlistMatrixRep"/> describes
## a matrix object (see <Ref Filt="IsMatrixObj"/>) that behaves similar to
## a list of its rows, in the sense of <Ref Filt="IsRowListMatrix"/>.
## <P/>
## <Ref Filt="IsPlistMatrixRep"/> implies <Ref Filt="IsCopyable"/>,
## <Ref Filt="IsRowPlistMatrixRep"/> implies <Ref Filt="IsCopyable"/>,
## thus matrix objects in this representation can be mutable.
## </Description>
## </ManSection>
Expand All @@ -97,13 +97,13 @@ DeclareRepresentation( "IsPlistVectorRep",
## </Item>
## </Enum>
## <P/>
## Any <A>obj</A> in <Ref Filt="IsPlistMatrixRep"/> satisfies that
## Any <A>obj</A> in <Ref Filt="IsRowPlistMatrixRep"/> satisfies that
## each entry in the stored plain list is a vector in
## <Ref Filt="IsPlistVectorRep"/>, whose base domain is identical with the
## stored base domain of <A>obj</A> and whose length is the stored number
## of columns.
##
DeclareRepresentation( "IsPlistMatrixRep",
DeclareRepresentation( "IsRowPlistMatrixRep",
IsRowListMatrix and IsPositionalObjectRep
and IsCopyable
and IsNoImmediateMethodsObject
Expand Down
Loading
Loading