Rename IsPlistMatrixRep to IsRowPlistMatrixRep#6227
Draft
Conversation
fingolfin
added
the
release notes: use title
ThomasBreuer
reviewed
Feb 9, 2026
Contributor
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
Apparently the CI tests of GAP.jl use IsPlistMatrixRep.
I have recently proposed to add some tests to the Forms package (branch TB_ConformalSymplecticGroup, almost merged) where I use IsPlistMatrixRep.
In both cases, the reason is to test functionality for some filter that describes a proper matrix object.
That is, it is only important that this is not IsPlistRep.
Do we have another constructing filter for matrix objects different from IsPlistMatrixRep that is suitable for testing purposes in packages?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we should do this or not... but I would like to revive PR #2973, or rather: make a new PR which instead of modifying
IsPlistMatrixRepcreates a new type which is not in theIsRowListMatrixfilter, and hence does not suffer from the performance penalty.The question is what to name the new type. One option would be to actually name the new type
IsPlistMatrixRepand rename the old type to e.g.IsRowPlistMatrixRep. There should be little existing code usingIsPlistMatrixRep. Certainly no packages use it; and I really wonder whether and why anyone should be using it in private code.So we could merge this PR; or we could wait for a future PR that adds a new "generic" matrixobj type and then rename the old type. Or the new type gets a new name.