Skip to content

Conversation

@lmagyar
Copy link

@lmagyar lmagyar commented Jan 8, 2026

Proposed Changes

Continuation of / supersedes #1260.

Plus fixed some things:

  • handle race condition in _check_api_key()
  • handle token expiration
  • handle token invalidation
  • fix argument validation condition
  • fix attribute initialization
  • remove magic constant
  • add tests

Plus added possibility to automatically store and retrieve the received OAuth token.

Related Issues

closes #1260 #1140

clayrosenthal and others added 3 commits January 8, 2026 00:58
- handle race condition in _check_api_key()
- handle token expiration
- handle token invalidation
- fix argument validation condition
- fix attribute initialization
- remove magic constant
- add tests
@clayrosenthal
Copy link
Contributor

Nice work! This seems like all great improvements over my first step. I don't have any faith at this point that @frenck even looks at this repo, but we can dream

@frenck
Copy link
Owner

frenck commented Jan 12, 2026

Nice work! This seems like all great improvements over my first step. I don't have any faith at this point that @frenck even looks at this repo, but we can dream

I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants