Skip to content

Conversation

@clayrosenthal
Copy link
Contributor

@clayrosenthal clayrosenthal commented Nov 10, 2025

Proposed Changes

Implementing basic oauth support. Allows for passing an oauth client id and secret to the Tailscale class. Checkout tailscale's docs for more information

Related Issues

Add support for oauth clients #1140

@clayrosenthal clayrosenthal changed the title oauth support new-feature: oauth support Nov 10, 2025
@clayrosenthal clayrosenthal force-pushed the oauth-support branch 2 times, most recently from f2724d0 to efc9d08 Compare November 10, 2025 02:50
@clayrosenthal
Copy link
Contributor Author

@frenck Can you take a look at the coverage failure? No idea why it's failing, code coverage runs fine on my local side

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Dec 12, 2025
@clayrosenthal
Copy link
Contributor Author

Anything from the actual maintainer or is this repo totally unmaintained?

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Dec 16, 2025
@lmagyar lmagyar mentioned this pull request Jan 8, 2026
@lmagyar
Copy link

lmagyar commented Jan 8, 2026

FYI #1314 supersedes this PR (this commit and author is preserved there)

There I fixed some things:

  • handle race condition in _check_api_key()
  • handle token expiration
  • handle token invalidation
  • fix argument validation condition
  • fix attribute initialization
  • remove magic constant
  • add tests

Plus added possibility to automatically store and retrieve the received OAuth token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants