Handle unsupported attributes in Markdown conversion + horizontal lines #418
Conversation
…al rules for dark themes
# Conflicts: # packages/fleather/lib/src/widgets/editor.dart # packages/fleather/lib/src/widgets/theme.dart
…headings localizations
# Conflicts: # packages/fleather/lib/src/widgets/editor_toolbar.dart
|
Thank you @maelchiotti, will take a look as soon as I find some time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 87.94% 87.97% +0.02%
==========================================
Files 62 62
Lines 10364 10443 +79
==========================================
+ Hits 9115 9187 +72
- Misses 1249 1256 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you @maelchiotti for this PR and very sorry for the late review
See my comments inline
More generally, you seem to tackle only the decoding part, did you intentionally ignore the encoding?
Also, we had mentioned the replacement of unsupported embeds with [object]
Lastly, can you prove this works with some tests please and remove the localization file from the PR?
Thanks!
There was a problem hiding this comment.
@maelchiotti let me know if you want me to contribute to your PR
|
Thanks, I'll take a look at your review in a week or two, work on the encoding part that is missing, and I'll let you know where I could use some help! |
…ported_attributes' into markdown_conversion_handle_unsupported_attributes
|
@amantoux I made the changes you requested in the comments, and added the [object] replacement. I did not handle the decoding part (you mixed up encoding and decoding in your comment btw) because I couldn't really understand how it works. Feel free to do it yourself and I'll read your code to see how you did it. I've also added a very simple test for the encoding, let me know if you think I should write more to cover more cases? |
|
@maelchiotti Sorry it has been a while, if you are interested in resuming this PR, can you please rebase? |
|
Hi @amantoux ! Yes completing this would be great. I'll rebase and take a quick look at what was missing. I'll let you know! |
Hi @maelchiotti, any chance to rebase sometime soon? I know we are all busy, just a gentle reminder 😀 |
|
Hi @amantoux thanks for the reminder! I'm slowing down development on my note taking app to have more time on another project. So sadly, I won't work on this anymore. Of course feel free to use the bits of code I've written so far! |
|
Sorry to here that |
2 participants
fixes #405