fix(ssl): Add --non-interactive flag to certbot commands#109
Merged
Conversation
Code Review SummaryThis PR fixes a critical issue where Certbot would hang in non-TTY environments (like Docker) by adding the 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Certbot fails with EOF error when run via docker without a TTY because it tries to prompt for Terms of Service confirmation. Adding --non-interactive prevents this and allows the webroot challenge to complete successfully. Also: - Make SSL manager executor injectable for testability - Gracefully skip SSL when certbot email is not configured - Accept certbot_email in setup wizard settings endpoint - Add ACME challenge location to nginx default server Signed-off-by: nfebe <fenn25.fn@gmail.com>
Nextcloud template was missing the required top-level name field and used direct port mapping instead of the proxy network. Aligned with other templates: use expose, container_name, and proxy network for nginx reverse proxying. Signed-off-by: nfebe <fenn25.fn@gmail.com>
The compose expose field was not parsed, so changes to it never propagated to service.yml. Added Expose to composeService struct, use it for container port extraction and primary service detection, and regenerate service.yml metadata when compose file is updated. Closes #104 Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/certbot-non-interactive
branch
from
7935b8e to
941f1d1
Compare
Signed-off-by: nfebe <fenn25.fn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certbot fails with EOF error when run via docker without a TTY because it tries to prompt for Terms of Service confirmation. Adding --non-interactive prevents this and allows the webroot challenge to complete successfully.
Also:
Also resolves: #104, #108