Skip to content

enh: Propagate SaveMetadata errors during compose updates #110

@nfebe

Description

@nfebe

Context

From PR #109 review.

When UpdateComposeFile syncs metadata to service.yml, the return value of SaveMetadata is silently ignored. If saving fails, the compose file is updated but service.yml is stale — an inconsistent state.

Location

internal/docker/discovery.goUpdateComposeFile(), around the d.SaveMetadata(name, existing) call.

Expected

Propagate the error:

if err := d.SaveMetadata(name, existing); err != nil {
    return fmt.Errorf("failed to sync service metadata: %w", err)
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions