Improve handling of Client Reply Context and SET requests #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github actions has deprecated the old way of returning results of an action. This updates the use of `::set-output` to the new way of writing into an environment file. also fix leftover reference version: Leftover from the previous versioning change that led to inconsistent versions across build and deploy. Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
force-pushed
the
dataSourceFixes
branch
from
b095fff to
2bc3d9f
Compare
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Error
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
- Future: set atomic to ready only after the reply has been set - ReplyQuery: only include entries from reply context, do not duplicate entries from request url - DataSourcePublisher.get: allow access to the reply context from the returned future - DataSourcePublsher subscription listener: fix handling of Context type none Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Allows to provide pre-serialised binary data to Set commands the same way as to receive non-deserialized data via the BinaryData special domain object. This is needed for use-cases which provide run-time dynamic set and get access e.g. via a map interface. Signed-off-by: Alexander Krimm <alex@wirew0rm.de>
wirew0rm
force-pushed
the
dataSourceFixes
branch
from
d92b9b8 to
0c14f64
Compare
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
changed the title
RalphSteinhagen
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Client was missing a way of communicating the reply context back to the caller for synchronous get requests, instead returning the request context. This led to missing information and was inconsistent with the async get and subscriptions, where the actual reply context was used.
For async get and subscriptions, the code for returning the context only worked for actual context objects, but was broken if the Context type was unspecified, in which case a map will be returned.
Also in the Future there was a (small) chance of a race condition, that was never observed, but from a logic standpoint, the atomic flag should only be set after the result object has been set.
Finally in the Worker, the replyContext caused lots of duplicate entries because it appended all fields from the request AND the reply context instead of just the reply context.
For set requests it was also not possible to pass arbitrary Objects by passing
BinaryDatathe same way it is possible for GET.In the CI this also fixes a few warnings.