fix: include macOS slice in universal hermes xcframework#56235
Closed
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Closed
fix: include macOS slice in universal hermes xcframework#56235Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
facebook-github-tools
bot
added
the
Shared with Meta
Consolidates the three separate Hermes Apple build scripts into a single `build-apple-framework.sh` that builds all platforms — including macOS — into one universal `hermesvm.xcframework`. Previously macOS was built as a standalone `.framework` by a separate script and excluded from the universal xcframework. This blocked SPM-based macOS builds since `Package.swift` references the universal xcframework. - Merge `build-ios-framework.sh` and `build-mac-framework.sh` into `build-apple-framework.sh` using the `PLATFORMS` array as single source of truth - Update podspec Pre-built subspec to point macOS at the universal xcframework (matching iOS, tvOS, and visionOS) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Saadnajmi
force-pushed
the
facebook/hermes-macos
branch
from
6fe1304 to
5852dc1
Compare
Contributor
|
Hey @Saadnajmi! As mentioned on discord, we don't build Hermes from React Native anymore. All the Hermes builds are happening in the hermes repo.
I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The context of this change is microsoft#2815 , where I am trying to add SPM / prebuild support to React Native macOS.
Currently, Hermes is compiled into 2 xcframeworks, a "maces" one with just the macosx slice, and a "universal" one for the rest of the iOS derived platforms (ios, xros, mac catalyst, etc). This means that React Native macOS would need some extra diffs and patches to "remember" to use the right hermes framework. However... xcframeworks are multiplatform and there's no reason we can't just add the macOS slice to the "universal" one.. making it more universal!
build-apple-framework.sh,build-ios-framework.sh,build-mac-framework.sh) into a singlebuild-apple-framework.shthat builds all platforms — including macOS — into one universalhermesvm.xcframeworkhermes-enginepodspec so the Pre-built subspec uses the universal xcframework for macOS (matching iOS, tvOS, and visionOS)Changelog:
[IOS] [FIXED] - include macOS slice in universal hermes xcframework
Test Plan:
Running a variant of this change in React Native macOS. CI wil be the ultimate answer for whether the changes are correct, so I'll be watching the PR jobs.