Fix StatusBar modifications not applying to Modal windows on Android#56059
Open
zoontek wants to merge 3 commits intofacebook:mainfrom
Open
Fix StatusBar modifications not applying to Modal windows on Android#56059zoontek wants to merge 3 commits intofacebook:mainfrom
zoontek wants to merge 3 commits intofacebook:mainfrom
Conversation
98c67ab to
e952685
Compare
300d032 to
27bb903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a
Modalis displayed on Android, it creates a newDialogwith its ownWindow. Modules likeStatusBarModuleonly apply their configuration to the main Activity's window, so status bar changes (style, visibility) are not reflected in Modal windows.This PR:
ExtraWindowEventListenerinStatusBarModuleto track extra windowsWindowextensionsetStatusBarStylefunction intoWindowUtil.ktfor reuseThis also fixes a race condition that occurs when opening a Modal and changing the status bar state at the same time.
Related issue
Changelog:
[ANDROID] [FIXED] - StatusBar configuration now applies to Modal windows, fixing visual inconsistencies
Test Plan:
transparent-modal.mp4