Add ExtraWindowEventListener interface#55721
Open
zoontek wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
3 tasks
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D94871845. |
zoontek
force-pushed
the
modal-system-bars-control
branch
8 times, most recently
from
9fdaf8d to
6620980
Compare
zoontek
force-pushed
the
modal-system-bars-control
branch
from
268f25a to
f832c91
Compare
zoontek
changed the title
zoontek
force-pushed
the
modal-system-bars-control
branch
from
f832c91 to
3791a05
Compare
zoontek
force-pushed
the
modal-system-bars-control
branch
from
3791a05 to
935b7de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a
ExtraWindowEventListenerinterface that allows native modules to be notified when new windows are created or destroyed (e.g. Modal dialogs).Third-party libraries can implement it, or emit window events through
ReactContext.onExtraWindowCreate/ReactContext.onExtraWindowDestroy.This opens the door for libraries like
expo-navigation-barto build a properNavigationBarmodule that stays in sync across all windows (including modals).Related issue
Changelog:
[ANDROID] [ADDED] - Add
ExtraWindowEventListenerinterface to allow native modules to react to window creation / destruction (e.g. Modal dialogs)Test Plan
Follow #56059 test plan