Skip to content

Fix UnsafeDereference: Replace !! with safe let in AndroidInfoHelpers #56041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdvacca wants to merge 6 commits into
base: main
Choose a base branch
from
+111 −2
Open

Fix UnsafeDereference: Replace !! with safe let in AndroidInfoHelpers #56041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59f497b
Fix MissingSoLoaderLibrary: Add @SoLoaderLibrary to ReactNativeJNISoL…
mdvacca Mar 10, 2026
8dec18a
Fix MissingSoLoaderLibrary: Add @SoLoaderLibrary to ReactNativeJniCom…
mdvacca Mar 10, 2026
f486317
Fix MissingSoLoaderLibrary: Add @SoLoaderLibrary to DefaultSoLoader
mdvacca Mar 10, 2026
79891b3
Fix MissingSoLoaderLibrary: Add @SoLoaderLibrary to InspectorNetworkR…
mdvacca Mar 10, 2026
5fd929d
Fix MissingOverrideAnnotation: Add @Override to YogaNodeJNIBase methods
mdvacca Mar 10, 2026
052c555
Fix UnsafeDereference: Replace !! with safe let in AndroidInfoHelpers
mdvacca Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...act-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactNativeJNISoLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ package com.facebook.react.bridge

import com.facebook.react.common.annotations.internal.InteropLegacyArchitecture
import com.facebook.soloader.SoLoader
import com.facebook.soloader.annotation.SoLoaderLibrary

@SoLoaderLibrary("reactnativejni")
@InteropLegacyArchitecture
internal object ReactNativeJNISoLoader {

Expand Down
2 changes: 2 additions & 0 deletions ...tive/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactNativeJniCommonSoLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
package com.facebook.react.bridge

import com.facebook.soloader.SoLoader
import com.facebook.soloader.annotation.SoLoaderLibrary

@SoLoaderLibrary("reactnativejni_common")
internal object ReactNativeJniCommonSoLoader {

@JvmStatic
Expand Down
2 changes: 2 additions & 0 deletions ...es/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultSoLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
package com.facebook.react.defaults

import com.facebook.soloader.SoLoader
import com.facebook.soloader.annotation.SoLoaderLibrary

@SoLoaderLibrary("react_newarchdefaults")
internal object DefaultSoLoader {
@Synchronized
@JvmStatic
Expand Down
2 changes: 2 additions & 0 deletions .../src/main/java/com/facebook/react/devsupport/inspector/InspectorNetworkRequestListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@ import com.facebook.jni.HybridData
import com.facebook.proguard.annotations.DoNotStrip
import com.facebook.proguard.annotations.DoNotStripAny
import com.facebook.soloader.SoLoader
import com.facebook.soloader.annotation.SoLoaderLibrary

/**
* JNI wrapper for `jsinspectormodern::NetworkRequestListener`. Handles the `ScopedExecutor`
* callback use on the C++ side.
*/
@SoLoaderLibrary("reactnativejni")
@DoNotStripAny
internal class InspectorNetworkRequestListener(
@field:DoNotStrip private val mHybridData: HybridData
Expand Down
4 changes: 2 additions & 2 deletions ...ve/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ public object AndroidInfoHelpers {

@Synchronized
private fun getMetroHostPropValue(): String {
if (metroHostPropValue != null) {
return metroHostPropValue!!
metroHostPropValue?.let {
return it
}
var process: Process? = null
var reader: BufferedReader? = null
Expand Down
Loading
Loading