Fix UnsafeDereference: Replace !! with safe let in AndroidInfoHelpers#56041
Open
mdvacca wants to merge 6 commits intofacebook:mainfrom
Open
Fix UnsafeDereference: Replace !! with safe let in AndroidInfoHelpers#56041mdvacca wants to merge 6 commits intofacebook:mainfrom
mdvacca wants to merge 6 commits intofacebook:mainfrom
Conversation
…oader (facebook#56036) Summary: Fixed MissingSoLoaderLibrary lint error in ReactNativeJNISoLoader.kt. Added SoLoaderLibrary("reactnativejni") annotation to the class which calls SoLoader.loadLibrary("reactnativejni") but was missing the annotation needed for build tools to sanity check JNI merging. changelog: [internal] internal Differential Revision: D95412950
…monSoLoader
Summary:
Fixed MissingSoLoaderLibrary lint error in ReactNativeJniCommonSoLoader.kt.
Added SoLoaderLibrary("reactnativejni_common") annotation to the class which calls SoLoader.loadLibrary("reactnativejni_common") but was missing the annotation needed for build tools to sanity check JNI merging.
changelog: [internal] internal
Reviewed By: javache
Differential Revision: D95412980
Summary:
Fixed MissingSoLoaderLibrary lint error in DefaultSoLoader.kt.
Added SoLoaderLibrary("react_newarchdefaults") annotation to the class which calls SoLoader.loadLibrary("react_newarchdefaults") but was missing the annotation needed for build tools to sanity check JNI merging.
changelog: [internal] internal
Differential Revision: D95413024
…equestListener
Summary:
Fixed MissingSoLoaderLibrary lint error in InspectorNetworkRequestListener.kt.
Added SoLoaderLibrary("reactnativejni") annotation to the class which calls SoLoader.loadLibrary("reactnativejni") but was missing the annotation needed for build tools to sanity check JNI merging.
changelog: [internal] internal
Differential Revision: D95413051
Summary: Fixed 101 MissingOverrideAnnotation lint errors in YogaNodeJNIBase.java. Added Override annotation to all public methods that override abstract methods from the YogaNode superclass but were missing the annotation. This includes style getters/setters (direction, flex, margin, padding, border, position, width, height, min/max dimensions, aspect ratio, gap), layout methods (reset, calculateLayout, dirty), tree manipulation (addChildAt, removeChildAt, indexOf), and measurement/baseline functions. changelog: [internal] internal Differential Revision: D95413075
Summary: Fixed UnsafeDereference lint error in AndroidInfoHelpers.kt. Replaced unsafe non-null assertion (metroHostPropValue!!) with a safe let expression to handle the nullable value properly. changelog: [internal] internal Differential Revision: D95413107
meta-cla
bot
added
the
CLA Signed
cortinico
approved these changes
Mar 10, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed UnsafeDereference lint error in AndroidInfoHelpers.kt.
Replaced unsafe non-null assertion (metroHostPropValue!!) with a safe let expression to handle the nullable value properly.
changelog: [internal] internal
Differential Revision: D95413107