Add protobuf 33.4.envoy module with configurable zlib dependency #3660
+332
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf's
gzip_streamtarget hardcodes@zlib, causing header conflicts when Envoy uses@zlib-ng(GCC fails withZLIB_VERSIONredefinition under-Werror).Changes
Created custom protobuf module at
bazel-registry/modules/protobuf/33.4.envoy/:33.4.envoylabel_flagfor configurable zlib dependency (//:zlib)src/google/protobuf/io/BUILD.bazelfrom@zlibto//:zlibUsage
In Envoy's
.bazelrc:The label_flag defaults to
@zlibfor backward compatibility but allows external override to any zlib implementation.Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.