-
Notifications
You must be signed in to change notification settings - Fork 15
bazel-registry: expose prebuilt protoc binaries in bzlmod repos #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
11
commits into
copilot/add-protobuf-module-for-zlib
Choose a base branch
from
copilot/update-protoc-toolchain-exposure
base: copilot/add-protobuf-module-for-zlib
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
bazel-registry: expose prebuilt protoc binaries in bzlmod repos #3661
Copilot
wants to merge
11
commits into
copilot/add-protobuf-module-for-zlib
from
copilot/update-protoc-toolchain-exposure
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update protoc toolchain to expose protoc binary
bazel-registry: expose protoc binary in prebuilt toolchain repos
Jan 29, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
bazel-registry: expose protoc binary in prebuilt toolchain repos
bazel-registry: expose protoc binary in prebuilt toolchain repos for bzlmod
Jan 29, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
bazel-registry: expose protoc binary in prebuilt toolchain repos for bzlmod
bazel-registry: expose protoc binary in prebuilt repos for bzlmod
Jan 29, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
bazel-registry: expose protoc binary in prebuilt repos for bzlmod
bazel-registry: make prebuilt protoc targets executable in bzlmod
Jan 29, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
bazel-registry: make prebuilt protoc targets executable in bzlmod
bazel-registry: expose prebuilt protoc binaries in bzlmod repos
Jan 29, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
bazel-registry: expose prebuilt protoc binaries in bzlmod repos
bazel-registry: expose prebuilt protoc binaries for bzlmod proto_toolchain resolution
Jan 29, 2026
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
bazel-registry: expose prebuilt protoc binaries for bzlmod proto_toolchain resolution
bazel-registry: expose prebuilt protoc binaries for bzlmod consumers
Jan 29, 2026
…es filegroup Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
bazel-registry: expose prebuilt protoc binaries for bzlmod consumers
bazel-registry: expose prebuilt protoc binaries in bzlmod repos
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bzlmod mode, protobuf's
@prebuilt_protoc.*repos don't expose the downloaded binary as a target. Downstream consumers fall back to compiling protoc from source, breaking builds that intentionally disable compilation (e.g., via--THIS_CC_TOOLCHAIN_IS_BROKEN).Changes
Patch
bazel/private/prebuilt_protoc_toolchain.bzlto generate BUILD targets in prebuilt repos:filegroupproduces single-file output (required by proto rules)Patch main
BUILD.bazel:config_settings (linux-x86_64, osx-aarch_64, win64, etc.)cc_binary(name = "protoc")→compiled_protocprotocalias withselect()routing to prebuilt binaries by platformAdditional patches:
label_flag(name = "zlib")for downstream configuration-Wno-deprecated-declarationsto default COPTS//:zliblabel_flagWhen
--@com_google_protobuf//bazel/toolchains:prefer_prebuilt_protocis set, Bazel routes to prebuilt binaries instead of compiling.Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.