Fix phasorplot legend handling, linewidth bugs, and bode improvements #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
no sure about bode plots , @engineerjoe440 should review it |
engineerjoe440
approved these changes
Jan 22, 2026
Owner
engineerjoe440
left a comment
engineerjoe440
left a comment
There was a problem hiding this comment.
Great cleanups and sanitation of inputs! Thank you!
|
|
||
| # Prevent invalid log10 values | ||
| if mn <= 0: | ||
| mn = 1e-12 |
Owner
There was a problem hiding this comment.
Should we consider making this a global variable if we're reusing it in multiple locations?
Owner
|
Test failures appear unrelated (but like something I'll need to investigate). @marcostfermin, can you link to the relevant issues that this pull request addresses? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.