Skip to content

Conversation

@marcostfermin
Copy link

@marcostfermin marcostfermin commented Jan 7, 2026

This PR combines 36 commits with significant refactoring of your codebase, bugfixes and almost double the test coverage you had. Your test coverage should be ~48% now.

miguelzaqui and others added 30 commits March 24, 2022 16:56
…uctance_functions

Parallel Plate Capacitor and Solenoid Inductance
…image-rendering-to-sphinx

Add Image Rendering to Sphinx build Plan
Updated the required stuff between lines 44 and 48 (both inclusive)
…arkhi-patch-1

Correct NumPy/SciPy/SymPy Casing in README
Correct NumPy/SciPy/SymPy Casing in Documentation
Refactor circle module for improved clarity and functionality.
- Refactor triangle class for clarity and correctness. 
- Update docstrings, improve type hints, and enhance validation for triangle properties.
Add broader tests across plotting and utility modules
Work in Progress
Add broader tests across plotting and utility modules
Expand module tests to cover more branches
Add electricpy __init__ coverage tests
Add broader tests across plotting and utility modules
Add geometry __init__ coverage tests
Respect signed transformer phase shifts
Add broader tests across plotting and utility modules
Add broader tests across plotting and utility modules
Add broader tests across plotting and utility modules
Allow rtdtemp without rounding
Expand triangle module tests
Simple test to return the version of the package
@Lakshmikanth2001
Copy link
Contributor

@marcostfermin thank you for the work, its not humalny possible to review 473 files changes over 620 commits an you break this PR into 3 or 4 commits and into mutiple PRs as well so that @JoeStanleySEL and I can review it

thank you ones again =

@marcostfermin
Copy link
Author

@Lakshmikanth2001 My apologies for pushing everything at once. Is 50 files per PR reasonable?

@Lakshmikanth2001
Copy link
Contributor

if file changes are small 20 is will work and if its one line or new files 30 would work , make sure you split it across multiple prs , will also double check with @JoeStanleySEL , @engineerjoe440

@marcostfermin
Copy link
Author

if file changes are small 20 is will work and if its one line or new files 30 would work , make sure you split it across multiple prs , will also double check with @JoeStanleySEL , @engineerjoe440

Sounds good! I’ll split this into ~15-20 PRs, keeping new test files around 30 per PR and more substantial changes around 20. Will start submitting them once I’m at my computer.

@marcostfermin
Copy link
Author

Split into 8 smaller PRs as requested:
#144: New test files (core)
#145: New test files (modules)
#146: Modified test files
#147: Geometry module
#148: Visualization & phasors
#149: Constants & conversions
#150: Simulation & computation
#151: Core init & utilities
Closing this PR in favor of the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.