-
Notifications
You must be signed in to change notification settings - Fork 21
Comprehensive refactoring of code logic, bugfixes and test expansions #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…uctance_functions Parallel Plate Capacitor and Solenoid Inductance
…test Moved to a MaterialUI Theme
…image-rendering-to-sphinx Add Image Rendering to Sphinx build Plan
Updated the required stuff between lines 44 and 48 (both inclusive)
…arkhi-patch-1 Correct NumPy/SciPy/SymPy Casing in README
…arkhi-patch-2 Update CONTRIBUTING.md
Correct NumPy/SciPy/SymPy Casing in Documentation
…eometry equality, bugs and logic
Refactor circle module for improved clarity and functionality.
- Refactor triangle class for clarity and correctness. - Update docstrings, improve type hints, and enhance validation for triangle properties.
Add broader tests across plotting and utility modules
Short Combined Test
Work in Progress
Add broader tests across plotting and utility modules
Expand module tests to cover more branches
Add electricpy __init__ coverage tests
Add broader tests across plotting and utility modules
Add geometry __init__ coverage tests
Respect signed transformer phase shifts
Add broader tests across plotting and utility modules
Add broader tests across plotting and utility modules
Add broader tests across plotting and utility modules
Allow rtdtemp without rounding
Expand triangle module tests
Simple test to return the version of the package
|
@marcostfermin thank you for the work, its not humalny possible to review thank you ones again = |
|
@Lakshmikanth2001 My apologies for pushing everything at once. Is 50 files per PR reasonable? |
|
if file changes are small 20 is will work and if its one line or new files 30 would work , make sure you split it across multiple prs , will also double check with @JoeStanleySEL , @engineerjoe440 |
Sounds good! I’ll split this into ~15-20 PRs, keeping new test files around 30 per PR and more substantial changes around 20. Will start submitting them once I’m at my computer. |
|
Split into 8 smaller PRs as requested: |
This PR combines 36 commits with significant refactoring of your codebase, bugfixes and almost double the test coverage you had. Your test coverage should be ~48% now.