-
Notifications
You must be signed in to change notification settings - Fork 92
Fix Elixir 1.20 compilation warnings #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| elixir 1.20.0-rc.6 | ||
| erlang 27.3.3 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -423,7 +423,7 @@ defmodule Gettext.Compiler do | |
| :parallel -> | ||
| grouped | ||
| |> Enum.map(fn {module, files} -> | ||
| Kernel.ParallelCompiler.async(fn -> | ||
| Task.async(fn -> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It must use the Kernel.ParallelCompiler.pmap. Using Task is wrong as it cannot track modules.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You will also need to bump the minimum Elixir version on mix.exs and CI. |
||
| compile_split_po_files(env, module, files, plural_mod, opts[:interpolation]) | ||
| end) | ||
| end) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -388,11 +388,6 @@ defmodule Gettext.Extractor do | |
| end | ||
| end | ||
|
|
||
| defp ensure_empty_msgstr!(%Message.Plural{} = message) do | ||
| raise Error, | ||
| "plural message with msgid '#{IO.iodata_to_binary(message.msgid)}' has a non-empty msgstr" | ||
| end | ||
|
|
||
|
Comment on lines
-391
to
-395
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was dead code, correct? |
||
| defp blank?(str) when not is_nil(str), do: IO.iodata_length(str) == 0 | ||
| defp blank?(_), do: true | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file :)