Fix Elixir 1.20 compilation warnings#433
Open
gilbertwong96 wants to merge 1 commit into
Open
Conversation
josevalim
reviewed
May 26, 2026
| grouped | ||
| |> Enum.map(fn {module, files} -> | ||
| Kernel.ParallelCompiler.async(fn -> | ||
| Task.async(fn -> |
Contributor
There was a problem hiding this comment.
It must use the Kernel.ParallelCompiler.pmap. Using Task is wrong as it cannot track modules.
Contributor
There was a problem hiding this comment.
You will also need to bump the minimum Elixir version on mix.exs and CI.
josevalim
reviewed
May 26, 2026
Contributor
There was a problem hiding this comment.
Please remove this file :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve compilation warnings in Elixir 1.20.