Skip to content

feat: build ROOT against external llvm #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wdconinc wants to merge 7 commits into
base: master
Choose a base branch
from
+11 −3
Open

feat: build ROOT against external llvm #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3b2b3c9
feat: build ROOT against external llvm
wdconinc May 14, 2026
cdfe39a
fix: spack cherry-pick: root: miscellaneous
wdconinc May 14, 2026
01f12eb
fix: rm duplicate cherry-pick
wdconinc May 15, 2026
9bb9f12
fix: apt-get install libllvm${CLANG}-dev
wdconinc May 16, 2026
8b8259f
fix: libllvm-dev => llvm-dev
wdconinc May 16, 2026
29c5f89
fix: apt-get install libedit-dev
wdconinc May 18, 2026
e25b423
fix: use eic-spack with cling CMake fix for external LLVM
wdconinc May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion containers/debian/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ fi
# Install packages
apt-get -yqq update
apt-get -yqq install cpp${GCC} gcc${GCC} g++${GCC} gfortran${GCC}
apt-get -yqq install clang${CLANG} clang-tidy${CLANG} clang-format${CLANG} libclang${CLANG}-dev libc++${CLANG}-dev
apt-get -yqq install clang${CLANG} clang-tidy${CLANG} clang-format${CLANG} libclang${CLANG}-dev libc++${CLANG}-dev libedit-dev llvm${CLANG}-dev
apt-get -yqq autoremove
# Remove symlinks loop in nvidia/cuda:12.5.1-devel-ubuntu24.04
rm -f /usr/bin/cpp /etc/alternatives/cpp
Expand Down
2 changes: 1 addition & 1 deletion eic-spack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ EICSPACK_ORGREPO="eic/eic-spack"

## EIC spack commit hash or github version, e.g. v0.19.7
## note: nightly builds could use a branch e.g. releases/v0.19
EICSPACK_VERSION="ce2dc68e4f75299f7a684708788870282ecde53a"
EICSPACK_VERSION="099c98ec5652a11fe255a532860eafcd56d52c9c"
2 changes: 1 addition & 1 deletion spack-environment/packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ packages:
root:
require:
- '@6.38.00'
- cxxstd=20 +fftw +fortran +gdml +http -ipo +mlp +python +root7 +tmva +tmva-sofie +x +xrootd +ssl
- cxxstd=20 ~builtin_llvm +fftw +fortran +gdml +http -ipo +mlp +python +root7 +tmva +tmva-sofie +x +xrootd +ssl
- any_of: [+opengl +webgui, -opengl -webgui]
sherpa:
require:
Expand Down
8 changes: 8 additions & 0 deletions spack-packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ b17f3abec760256ad7faf1b1d102f2553d6a3622
045873c8cbce3eef07ed068a998467e01bd91129
b11529d6bbd8abc9f7bde6faf290b1c22385a022
9d1b52d36a4c89d9c3964f599cd00232b901e9ac
30e69adca31b9ba98e61c42b4126188911e3537c
93acd58e1399d787dac69d61ecbbd1695c8a2bac
ad4b252d254d49db587abd6fd06c375c71d27a01
8cd9959e3fd4e54d79bbf75210e335ab842e1af0
---
## Optional hash table with comma-separated file list
## For these commits, the cherry-pick will be restricted to the listed files only.
Expand Down Expand Up @@ -57,3 +61,7 @@ read -r -d '' SPACKPACKAGES_CHERRYPICKS_FILES <<- \
## 045873c8cbce3eef07ed068a998467e01bd91129: py-snakemake-storage-plugin-pelican: new package v0.1.1 + deps
## b11529d6bbd8abc9f7bde6faf290b1c22385a022: py-onnxruntime: only run tests when self.run_tests
## 9d1b52d36a4c89d9c3964f599cd00232b901e9ac: julia: avoid cascading mbedtls in v1.12+
## 30e69adca31b9ba98e61c42b4126188911e3537c: root: cleanup recipe since the minimum version is 6.28.00
## 93acd58e1399d787dac69d61ecbbd1695c8a2bac: Miscellaneous package fixes
## ad4b252d254d49db587abd6fd06c375c71d27a01: root: add v6.36.12
## 8cd9959e3fd4e54d79bbf75210e335ab842e1af0: root: add builtin_llvm variant to allow external LLVM
Loading