feat: build ROOT against external llvm#288
Open
wdconinc wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables building ROOT against an external LLVM (instead of ROOT's bundled copy) by adding ~builtin_llvm to the ROOT require list, and pulls in the corresponding spack-packages cherry-pick that introduces the builtin_llvm variant.
Changes:
- Add cherry-pick
8cd9959etospack-packages.shthat adds thebuiltin_llvmvariant to the ROOT package recipe. - Add
~builtin_llvmto the ROOT requirements inspack-environment/packages.yamlto use the external LLVM.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spack-packages.sh | Adds new spack-packages cherry-pick hash and matching descriptive comment for the ROOT builtin_llvm variant. |
| spack-environment/packages.yaml | Adds ~builtin_llvm to ROOT's required variants, switching to external LLVM. |
wdconinc
force-pushed
the
root-external-llvm
branch
from
901a1d3 to
ac164f0
Compare
wdconinc
force-pushed
the
root-external-llvm
branch
from
52caa62 to
2b36d4d
Compare
wdconinc
force-pushed
the
root-external-llvm
branch
from
97f979c to
4881ab5
Compare
Added installation of libllvm for Clang support.
Point to eic/eic-spack#932 which guards the BEFORE flag in interpreter/cling/CMakeLists.txt include_directories to only apply when builtin_llvm=ON. With external LLVM, the unconditional BEFORE caused LLVM's libc++abi cxxabi.h to shadow GCC 14's cxxabi.h, producing a conflicting declaration of __cxa_init_primary_exception. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
root-external-llvm
branch
from
4881ab5 to
e25b423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
ROOT includes its version of llvm, but it should be possible to build against an external llvm. With ROOT 6.36, that external llvm is at the same level as what ROOT requires. This PR enables the external llvm build.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply