chore(deps-dev): bump @types/node from 22.18.3 to 24.4.0#168
Closed
dependabot[bot] wants to merge 1 commit into
Closed
chore(deps-dev): bump @types/node from 22.18.3 to 24.4.0#168dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.18.3 to 24.4.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 24.4.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
Author
|
Superseded by #171. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/types/node-24.4.0
branch
2 tasks
edobry
added a commit
that referenced
this pull request
Apr 3, 2026
… in prepare-pr ## Summary Remove `branchNameToTaskId()` — it reintroduced fragile string parsing that the UUID refactor was meant to eliminate. The DB record (`SessionRecord.taskId`) is the source of truth for task linkage. Also remove ~420 lines of redundant self-repair code from `preparePrImpl` and `preparePr`. The session DB is already wrapped with `SessionAutoRepairProvider` which handles orphaned sessions at the provider layer — the self-repair in the PR functions was dead weight. ### Changes - **task-id.ts**: Delete `branchNameToTaskId()`, update `@deprecated` JSDoc to reference DB lookup - **prepare-pr-operations.ts**: Remove ~210-line self-repair block (TASK #168), replace with simple error. Remove 7 unused imports. - **prepare-pr.ts**: Same treatment — remove self-repair, simplify error - **backend-qualified-id.ts**: Remove `@deprecated` reference to deleted function - **multi-backend-integration.test.ts**: Remove 5 self-repair tests, add test verifying no self-repair at this layer ### Net: -420 lines of redundant code ## Test plan - [x] 371 tests pass in src/domain/git/ - [ ] Full test suite passes
3 tasks
edobry
added a commit
that referenced
this pull request
Apr 6, 2026
## Summary Eliminates all remaining `mock.module()` calls from the test suite, bringing the count to **zero**. ### Deleted 5 low-value/redundant test files (10 mock.module calls removed): - `real-world-workflow.test.ts` — only tested mock objects, no production code coverage - `multi-backend-real-integration.test.ts` — duplicated unit test coverage with fs mocks - `session-lookup-bug-simple.test.ts` — bug reproduction test for fixed bug (#168) - `session-lookup-bug-reproduction.test.ts` — bug reproduction test for fixed bug (#168) - `session-edit-file-simplified.integration.test.ts` — gated on `RUN_INTEGRATION_TESTS`, never runs in CI ### Removed mock.module() from 5 kept test files (5 mock.module calls removed): - `tests/adapters/cli/session.test.ts` — removed fs mock (production code uses DI, tested functions don't touch fs) - `tests/adapters/cli/session-update.test.ts` — removed fs mock (same reason) - `session-approve-bugfix-regression.test.ts` — removed logger mock (just noise suppression, not asserted) - `migrate-backend-validation.test.ts` — removed logger mock (same) - `commit-msg.test.ts` — removed logger mock (same) ### Verification - All 1572 tests pass, 0 failures - `grep -r "mock.module(" --include="*.test.ts"` returns only comments, zero actual calls ## Test plan - [x] All 5 modified test files pass individually - [x] Full test suite passes (1572 pass, 0 fail) - [x] Zero `mock.module()` calls remain in codebase (verified via grep)
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
- Add failing test that reproduces session directory orphaning bug - Fix GitService.clone to move directory creation after validation - Add cleanup logic when git clone fails to prevent orphaned directories Addresses Task #168: Sessions exist on disk but not in database
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
- Updated mock test to reflect fixed GitService behavior - Added integration test that validates real GitService cleanup - Confirmed both tests pass, demonstrating bug is fixed - Session directories are properly cleaned up when git clone fails Fix successfully prevents orphaned session directories per Task #168
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
- Fixed CLI main module detection using import.meta.main instead of unreliable URL comparison - Added proper error handling and debugging in CLI main function - Use type assertions for process.argv instead of custom type declarations - CLI now properly outputs help, errors, and success messages as expected - Resolves issue where session pr and other commands were silently failing
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
…leshooting - Added detailed logging to understand session database lookup process - Helps diagnose issues when sessions exist on disk but aren't found in database - Logs database path, lookup results, and available sessions for debugging
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
- Changed database path from ~/.local/state/minsky/session-db.json to ~/.local/state/minsky/minsky/session-db.json - Resolves issue where sessions exist on disk but aren't found in database - The actual session database was located in the minsky subdirectory, not at the root level - This fix ensures session pr and other commands can find existing sessions correctly
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
- Reverted SessionDB constructor to use original correct path: ~/.local/state/minsky/session-db.json - Moved actual database from nested location to correct root location - Database access now works correctly from all contexts - Session list command confirms task#168 can be found in database
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
…ession database lookup - Modified sessionPrFromParams to use repo path directly when --repo is provided - Bypasses session database lookup when working with repo paths - Enables session pr command to work from session workspaces without database issues - Maintains backward compatibility with session-based workflow
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
… session update - Enhanced error message for merge conflicts in preparePr method - Provides clear step-by-step instructions to resolve conflicts - Guides users to use 'minsky session update' to sync with main branch - Includes alternative approaches and helpful tips - Makes the conflict resolution workflow more user-friendly
edobry
added a commit
that referenced
this pull request
Apr 19, 2026
- Enhanced error message for merge conflicts during session update - Provides clear step-by-step instructions to resolve conflicts - Includes alternative approaches for different scenarios - Shows exact git commands needed to resolve conflicts - Makes the session update conflict resolution workflow more user-friendly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @types/node from 22.18.3 to 24.4.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)