refactor(mt#649): Remove branchNameToTaskId and redundant self-repair in prepare-pr#292
Merged
Conversation
- Delete branchNameToTaskId() from src/domain/tasks/task-id.ts - Update @deprecated JSDoc on sessionNameToTaskId to reference DB lookup instead - Update @deprecated comment in backend-qualified-id.ts to not reference branchNameToTaskId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
branchNameToTaskId()— it reintroduced fragile string parsing that the UUID refactor was meant to eliminate. The DB record (SessionRecord.taskId) is the source of truth for task linkage.Also remove ~420 lines of redundant self-repair code from
preparePrImplandpreparePr. The session DB is already wrapped withSessionAutoRepairProviderwhich handles orphaned sessions at the provider layer — the self-repair in the PR functions was dead weight.Changes
branchNameToTaskId(), update@deprecatedJSDoc to reference DB lookup@deprecatedreference to deleted functionNet: -420 lines of redundant code
Test plan