releng: Build with tracecompass-e4.39 by default#388
releng: Build with tracecompass-e4.39 by default#388arfio merged 1 commit intoeclipse-tracecompass:stable-11.3from
Conversation
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
📝 WalkthroughWalkthroughThis PR updates the Eclipse target platform from e4.38 to e4.39 in the Maven build configuration, reorganizes plugin dependencies between main and legacy feature files (moving OSGi/Felix/Ant/Jsch plugins from legacy to main), removes ECF SSL features from the main product, and adds them to the legacy product configuration. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pom.xml`:
- Line 60: The build is missing registration for the e4.39 target in
releng/org.eclipse.tracecompass.target's pom.xml: update the
build-helper-maven-plugin configuration (attach-artifacts section) to add an
artifact entry for the tracecompass-e4.39 target by declaring an artifact with
file name tracecompass-e4.39.target, type target and classifier
tracecompass-e4.39 so the e4.39 target is attached and published.
In `@rcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xml`:
- Around line 208-211: Remove the duplicate plugin declaration for
org.eclipse.swtchart from the feature.xml: locate the duplicate <plugin
id="org.eclipse.swtchart" .../> entry (the one added around the commented diff)
and delete it so only the original declaration (the earlier <plugin
id="org.eclipse.swtchart" version="0.0.0"/> entry) remains; ensure there is no
other duplicate plugin id left in the feature.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5263cd53-95ea-4a0b-a02c-420a23e31b9b
📒 Files selected for processing (5)
pom.xmlrcp/org.eclipse.tracecompass.rcp.product/legacy-e4.30-e4.38/tracing.productrcp/org.eclipse.tracecompass.rcp.product/tracing.productrcp/org.eclipse.tracecompass.rcp/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xml
💤 Files with no reviewable changes (1)
- rcp/org.eclipse.tracecompass.rcp.product/tracing.product
What it does
releng: Build with tracecompass-e4.39 target by default
How to test
Build in stable branch with default target.
Follow-ups
N/A
Review checklist
Summary by CodeRabbit