Skip to content

releng: Build with tracecompass-e4.39 by default#388

Merged
arfio merged 1 commit intoeclipse-tracecompass:stable-11.3from
arfio:stable-11.3
Apr 8, 2026
Merged

releng: Build with tracecompass-e4.39 by default#388
arfio merged 1 commit intoeclipse-tracecompass:stable-11.3from
arfio:stable-11.3

Conversation

@arfio
Copy link
Copy Markdown
Contributor

@arfio arfio commented Apr 8, 2026

What it does

releng: Build with tracecompass-e4.39 target by default

How to test

Build in stable branch with default target.

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Summary by CodeRabbit

  • Chores
    • Updated Eclipse target platform to version 4.39
    • Reorganized SSL and dependency configurations across legacy and current product variants
    • Adjusted plugin dependencies to align with platform version requirements

Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

This PR updates the Eclipse target platform from e4.38 to e4.39 in the Maven build configuration, reorganizes plugin dependencies between main and legacy feature files (moving OSGi/Felix/Ant/Jsch plugins from legacy to main), removes ECF SSL features from the main product, and adds them to the legacy product configuration.

Changes

Cohort / File(s) Summary
Build Configuration
pom.xml
Updated Maven/Tycho build property target-platform from tracecompass-e4.38 to tracecompass-e4.39.
Product Configuration (Main)
rcp/org.eclipse.tracecompass.rcp.product/tracing.product
Removed two ECF SSL feature inclusions: org.eclipse.ecf.core.ssl.feature and org.eclipse.ecf.filetransfer.ssl.feature.
Product Configuration (Legacy)
rcp/org.eclipse.tracecompass.rcp.product/legacy-e4.30-e4.38/tracing.product
Added two ECF SSL feature inclusions: org.eclipse.ecf.core.ssl.feature and org.eclipse.ecf.filetransfer.ssl.feature.
Feature Configuration
rcp/org.eclipse.tracecompass.rcp/feature.xml, rcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xml
Reorganized plugin declarations: removed org.eclipse.swtchart from main and added 20 plugins (Felix Gogo, OSGi services/utilities, Ant, Jsch); inverse changes applied to legacy e4.38 feature.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Suggested reviewers

  • bhufmann
  • MatthewKhouzam

Poem

🐰 From e4.38's nest to e4.39's bright meadow,
We shuffle our bundles, both new and mellow,
The swtchart hops to legacy's care,
While OSGi friends find homes everywhere,
ECF SSL guards the old and the bold! 🌿✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the Eclipse target platform to e4.39 as the default for builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arfio arfio changed the base branch from master to stable-11.3 April 8, 2026 17:51
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pom.xml`:
- Line 60: The build is missing registration for the e4.39 target in
releng/org.eclipse.tracecompass.target's pom.xml: update the
build-helper-maven-plugin configuration (attach-artifacts section) to add an
artifact entry for the tracecompass-e4.39 target by declaring an artifact with
file name tracecompass-e4.39.target, type target and classifier
tracecompass-e4.39 so the e4.39 target is attached and published.

In `@rcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xml`:
- Around line 208-211: Remove the duplicate plugin declaration for
org.eclipse.swtchart from the feature.xml: locate the duplicate <plugin
id="org.eclipse.swtchart" .../> entry (the one added around the commented diff)
and delete it so only the original declaration (the earlier <plugin
id="org.eclipse.swtchart" version="0.0.0"/> entry) remains; ensure there is no
other duplicate plugin id left in the feature.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5263cd53-95ea-4a0b-a02c-420a23e31b9b

📥 Commits

Reviewing files that changed from the base of the PR and between 1fa0d67 and 9ad4ef7.

📒 Files selected for processing (5)
  • pom.xml
  • rcp/org.eclipse.tracecompass.rcp.product/legacy-e4.30-e4.38/tracing.product
  • rcp/org.eclipse.tracecompass.rcp.product/tracing.product
  • rcp/org.eclipse.tracecompass.rcp/feature.xml
  • rcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xml
💤 Files with no reviewable changes (1)
  • rcp/org.eclipse.tracecompass.rcp.product/tracing.product

@arfio arfio requested a review from MatthewKhouzam April 8, 2026 18:19
@arfio arfio merged commit 56e9e50 into eclipse-tracecompass:stable-11.3 Apr 8, 2026
5 checks passed
@arfio arfio deleted the stable-11.3 branch April 8, 2026 21:03
@coderabbitai coderabbitai bot mentioned this pull request Apr 9, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant