Open
Conversation
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
📝 WalkthroughWalkthroughThis PR upgrades the Trace Compass build infrastructure from Eclipse 4.38 to 4.39, updates the baseline version from 11.2.0 to 11.3.0, refactors RCP feature definitions by consolidating OSGi service bundles into the main feature and moving charting dependencies to legacy support, and removes SSL-related ECF features from the main product. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@rcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xml`:
- Around line 208-210: Remove the duplicate plugin declaration for
org.eclipse.swtchart: locate the repeated <plugin id="org.eclipse.swtchart"
.../> stanza (the one that appears later in the legacy feature definition) and
delete that extra entry so only the original declaration remains; verify the
remaining single declaration (org.eclipse.swtchart) is the one at the earlier
position and that no other duplicate plugin ids are left in the feature.xml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2dbb88e2-9649-4305-9d5a-b89c043f3cb9
📒 Files selected for processing (7)
TraceCompass.setuppom.xmlrcp/org.eclipse.tracecompass.rcp.product/legacy-e4.30-e4.38/tracing.productrcp/org.eclipse.tracecompass.rcp.product/tracing.productrcp/org.eclipse.tracecompass.rcp/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xmlreleng/org.eclipse.tracecompass.target/baseline/tracecompass-baseline-11.3.0.target
💤 Files with no reviewable changes (1)
- rcp/org.eclipse.tracecompass.rcp.product/tracing.product
Comment on lines
+208
to
+210
| <plugin | ||
| id="org.eclipse.swtchart" | ||
| version="0.0.0"/> |
There was a problem hiding this comment.
Remove the duplicate org.eclipse.swtchart entry.
org.eclipse.swtchart is already declared at Line 56, so this extra stanza only duplicates the same plug-in in the legacy feature definition.
Proposed fix
- <plugin
- id="org.eclipse.swtchart"
- version="0.0.0"/>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <plugin | |
| id="org.eclipse.swtchart" | |
| version="0.0.0"/> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@rcp/org.eclipse.tracecompass.rcp/legacy-e4.38/feature.xml` around lines 208 -
210, Remove the duplicate plugin declaration for org.eclipse.swtchart: locate
the repeated <plugin id="org.eclipse.swtchart" .../> stanza (the one that
appears later in the legacy feature definition) and delete that extra entry so
only the original declaration remains; verify the remaining single declaration
(org.eclipse.swtchart) is the one at the earlier position and that no other
duplicate plugin ids are left in the feature.xml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
releng: Update OOMPH setup file for 11.3.0
releng: Add Trace Compass 11.3.0 baseline
releng: Build with tracecompass-e4.39 target by default
How to test
Build with default target
Set tracecompass-11.2.0 baseline
Setup with OOMPH
Follow-ups
N/A
Review checklist
Summary by CodeRabbit
New Features
Chores