Avoid cut-off symbols in Terminal on monitor zoom != 100%#2483
Draft
HeikoKlare wants to merge 2 commits intoeclipse-platform:masterfrom
Draft
Avoid cut-off symbols in Terminal on monitor zoom != 100%#2483HeikoKlare wants to merge 2 commits intoeclipse-platform:masterfrom
HeikoKlare wants to merge 2 commits intoeclipse-platform:masterfrom
Conversation
The terminal implementation uses a custom double buffering implementation for rendering the current line. On most Platforms (Linux and MacOS) the current implementation will always render the double-buffered image at 100% zoom, even if the target zoom is higher. This change adapts the implementation to directly render into the actual control and enable native double buffering for the control instead. This ensures that the contents are rendered at the actual target zoom, producing sharper results on HiDPI monitors when using MacOS or Linux. Fixes eclipse-platform#2295 Fixes eclipse-platform#2191 # Conflicts: # terminal/bundles/org.eclipse.terminal.control/src/org/eclipse/terminal/internal/textcanvas/TextLineRenderer.java
On monitors with zoom != 100% on Windows, symbols in the Terminal appear cut-off. This can be avoided by enabled advanced mode for the GC used for rendering the text.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On monitors with zoom != 100% on Windows, symbols in the Terminal appear cut-off. This can be avoided by enabled advanced mode for the GC used for rendering the text.
This PR includes and should thus be processed after:
This is a replacement for the PR enabling antialiasing which had to be reverted because of performance issues:
The change still has a performance impact, but it's much less severe than with the previous PR. We should test if the degradation is acceptable.
Before
After