split address bar option in onboarding translations #7622
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding_translations
branch
from
e2bed61 to
3d7c36f
Compare
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding
branch
2 times, most recently
from
b124213 to
9a6835b
Compare
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding_translations
branch
from
3d7c36f to
c3b2105
Compare
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding
branch
2 times, most recently
from
ceb10b8 to
b500a2e
Compare
aibrahim-
changed the title
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding_translations
branch
from
4e7436b to
9e62350
Compare
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding_translations
branch
from
9e62350 to
f5d93d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212608036467427/task/1213025850844445?focus=true
Description
Translations
Note
Low Risk
Low risk: resource-only translation updates with no behavior changes, limited to onboarding UI text.
Overview
Adds the missing
highlightsPreOnboardingAddressBarOption3Title/Descriptionstrings ("Split" / "Best of both") tovalues/strings.xmland provides translations for several locales (e.g.,values-bg,values-fi,values-lt,values-lv,values-nb,values-nl,values-pl).Removes those option-3 strings from
values/donottranslate.xmlso they are properly translated/localized.Written by Cursor Bugbot for commit 9ef26c0. This will update automatically on new commits. Configure here.