split address bar option in onboarding#7621
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding
branch
4 times, most recently
from
ceb10b8 to
b500a2e
Compare
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1213029344891220 |
aibrahim-
changed the title
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding
branch
3 times, most recently
from
dc728af to
36e7cea
Compare
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding
branch
from
36e7cea to
ac2a867
Compare
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding
branch
from
de05be5 to
d1c8515
Compare
aibrahim-
force-pushed
the
feature/aibrahim/split_option_onboarding
branch
from
d1c8515 to
b18ffeb
Compare
joshliebe
reviewed
Feb 2, 2026
joshliebe
reviewed
Feb 2, 2026
joshliebe
reviewed
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212608036467427/task/1212980921221776?focus=true
Description
Steps to test this PR
UI changes
| Before | After |
| 
|
Note
Medium Risk
Medium risk because it changes pre-onboarding UI flow and the persisted
omnibarTypeselection logic, gated by new remote-config toggles; regressions could affect new-user setup and metrics but is limited in scope.Overview
Adds a third “Split” address bar position choice to the pre-onboarding welcome flow, updating the UI to a new horizontal toggle layout and driving selection via
OmnibarType(top/bottom/split) instead of a boolean.Gates the split option behind a new remote-config sub-flag
splitOmnibarWelcomePage(in addition tosplitOmnibar), applies a safe fallback to top if split is selected while disabled, and introduces a new unique pixelm_preonboarding_split_address_bar_selected_unique(wired throughAppPixelName, pixel definitions, param-removal, and updated tests).Written by Cursor Bugbot for commit 6a34b9f. This will update automatically on new commits. Configure here.