Only export JNI and C-API symbols#164
Merged
Mytherin merged 1 commit intoduckdb:mainfrom Mar 17, 2025
Merged
Conversation
staticlibs
force-pushed
the
symbols_export
branch
from
7f6b6b5 to
9e574fd
Compare
Contributor
|
Thanks! LGTM - could you just look at the merge conflicts? |
Currently libduckdb_java.so shared lib exports all symbols. This is not good for a library that needs to be loaded into JVM process. Proposed change makes the shared lib to only export the JNI and C-API symbols. C-API symbols are exported with the intention to be used by C-API-based extensions. Testing: no functional changes, no new tests. Fixes: duckdb#102
staticlibs
force-pushed
the
symbols_export
branch
from
9e574fd to
36c50b7
Compare
Collaborator
Author
|
Thanks for the review! Rebased it onto the latest main. |
Contributor
|
Thanks! |
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Sep 16, 2025
This PR is a follow-up to duckdb#164 change, it fixes the exported symbols for MacOS and adds listing of symbols on CI runs.
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Sep 16, 2025
This PR is a follow-up to duckdb#164 change, it fixes the exported symbols for MacOS and adds listing of symbols on CI runs.
staticlibs
added a commit
that referenced
this pull request
Sep 16, 2025
This PR is a follow-up to #164 change, it fixes the exported symbols for MacOS and adds listing of symbols on CI runs.
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Sep 16, 2025
This is a backport of the PR duckdb#386 to `v1.4-andium` stable branch. This PR is a follow-up to duckdb#164 change, it fixes the exported symbols for MacOS and adds listing of symbols on CI runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently libduckdb_java.so shared lib exports all symbols. This is not good for a library that needs to be loaded into JVM process.
Proposed change makes the shared lib to only export the JNI and C-API symbols. C-API symbols are exported with the intention to be used by C-API-based extensions.
Testing: no functional changes, no new tests.
Fixes: #102