Remove java cross-comp options, include debuginfo#144
Merged
Mytherin merged 1 commit intoduckdb:mainfrom Mar 17, 2025
Merged
Conversation
staticlibs
force-pushed
the
jdk8_and_debug_flags
branch
from
91879ca to
c9895b0
Compare
When compiling Java part with JDK 11 (or later), the current javac options `-source 1.8` and `-tatget 1.8` are ineffective. Resulting bytecode format is compatible with JDK 8, but cannot be run on JDk 8 because it is compiled against the bootstrap classpath of JDK 11 and depends on methods not available in JDK 8. This change removes these cross-compilation flags. It is assumed, that official release binaries are always built with JDK 8. For users/packagers, who is going to build the driver from source, a CMake configure-time warning about JDK 8 compatibility is added. Additionally Java debuginfo is added to the JAR (`-g` flag). It does not affect the performance and the JAR size increase is minor (less than 10KB). Fixes: duckdb#143
staticlibs
force-pushed
the
jdk8_and_debug_flags
branch
from
c9895b0 to
648be7f
Compare
hannes
approved these changes
Mar 17, 2025
Member
hannes
left a comment
hannes
left a comment
There was a problem hiding this comment.
Great solution, did not know this was an issue
Collaborator
Author
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling Java part with JDK 11 (or later), the current javac options
-source 1.8and-tatget 1.8are ineffective. Resulting bytecode format is compatible with JDK 8, but cannot be run on JDK 8 because it is compiled against the bootstrap classpath of JDK 11 and depends on methods not available in JDK 8.This change removes these cross-compilation flags. It is assumed, that official release binaries are always built with JDK 8. For users/packagers, who is going to build the driver from source, a CMake configure-time warning about JDK 8 compatibility is added.
Additionally Java debuginfo is added to the JAR (
-gflag). It does not affect the performance and the JAR size increase is minor (less than 10KB).Fixes: #143