refactor: convert log calls to parameterized logging in test utilities#1305
Merged
joaodinissf merged 1 commit intoMay 19, 2026
Merged
Conversation
This was referenced Apr 6, 2026
joaodinissf
force-pushed
the
chore/pmd-guard-log/test-utilities
branch
from
faba54c to
99f9599
Compare
joaodinissf
force-pushed
the
chore/pmd-guard-log/test-utilities
branch
2 times, most recently
from
732bc16 to
23f155d
Compare
joaodinissf
force-pushed
the
chore/pmd-guard-log/test-utilities
branch
from
23f155d to
4631685
Compare
joaodinissf
force-pushed
the
chore/pmd-guard-log/test-utilities
branch
from
4631685 to
3d67160
Compare
rubenporras
requested changes
May 18, 2026
| @Override | ||
| public SwtBotButton click() { | ||
| log.debug("Clicking on {}", SWTUtils.getText(widget)); //$NON-NLS-1$ | ||
| log.debug("Clicking on {}", SWTUtils.getText(widget)); //$NON-NLS-1$ // NOPMD GuardLogStatement |
Member
There was a problem hiding this comment.
this and the next should be lamdas, right?
Collaborator
Author
There was a problem hiding this comment.
Actually this .debug() doesn't offer this signature, unfortunately. We can go with the if guard.
joaodinissf
force-pushed
the
chore/pmd-guard-log/test-utilities
branch
from
3d67160 to
7b00dae
Compare
rubenporras
previously approved these changes
May 19, 2026
Replace string concatenation in `LOGGER.x(...)` calls with parameterized `{}` placeholders, using `Supplier` lambdas for lazy argument evaluation. Adds NOPMD suppressions where the call site uses SwtBot's SLF4J logger (not Log4j) so the rule doesn't fire there, and adds `org.apache.logging.log4j.util` to the OSGi manifests of `test.core` and `test.ui` for the `Supplier` import.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/pmd-guard-log/test-utilities
branch
from
7b00dae to
1341011
Compare
rubenporras
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces string concatenation in
LOGGER.x(...)calls with parameterized{}placeholders, usingSupplierlambdas for lazy argument evaluation. Adds NOPMD suppressions where the call site uses SwtBot's SLF4J logger (not Log4j) so the rule doesn't fire there, and addsorg.apache.logging.log4j.utilto the OSGi manifests oftest.coreandtest.uifor theSupplierimport.🤖 Generated with Claude Code