refactor: convert log calls to parameterized logging in DDK core#1306
Merged
joaodinissf merged 1 commit intoMay 19, 2026
Merged
Conversation
This was referenced Apr 6, 2026
joaodinissf
force-pushed
the
chore/pmd-guard-log/ddk-core
branch
from
a2cd3fe to
c1495e1
Compare
joaodinissf
force-pushed
the
chore/pmd-guard-log/ddk-core
branch
2 times, most recently
from
64aef31 to
250ad6a
Compare
joaodinissf
force-pushed
the
chore/pmd-guard-log/ddk-core
branch
from
250ad6a to
6a53381
Compare
rubenporras
previously approved these changes
May 18, 2026
Replaces string concatenation, `NLS.bind`, and `MessageFormat.format` in `LOGGER.x(...)` calls with parameterized `{}` placeholders, using `Supplier`/method-refs for lazy argument evaluation. Extracts duplicate format strings to constants where they appear twice. Adds `org.apache.logging.log4j.util` to the `xtext` bundle's OSGi manifest for the `Supplier` import. Modules touched: `xtext`, `typesystem`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/pmd-guard-log/ddk-core
branch
from
6a53381 to
abe7b93
Compare
Collaborator
Author
|
@rubenporras fixed a minor nit, could you please re-review? |
rubenporras
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces string concatenation,
NLS.bind, andMessageFormat.formatinLOGGER.x(...)calls with parameterized{}placeholders, usingSupplier/method-refs for lazy argument evaluation. Extracts duplicate format strings to constants where they appear twice. Addsorg.apache.logging.log4j.utilto thextextbundle's OSGi manifest for theSupplierimport. Modules touched:xtext,typesystem.🤖 Generated with Claude Code