xUnit: remove defunct helpers, add deterministic init via assembly fixture#19344
Draft
majocha wants to merge 4 commits intodotnet:mainfrom
Draft
xUnit: remove defunct helpers, add deterministic init via assembly fixture#19344majocha wants to merge 4 commits intodotnet:mainfrom
majocha wants to merge 4 commits intodotnet:mainfrom
Conversation
Contributor
✅ No release notes required |
Contributor
Author
|
There is a deadlock in ComponentTests that can happen with xUnit v3 running tests in parallel: Locally I can see it with some tests calling Task.Wait and Task.Result directly. |
Synchronous Task.Wait and Task.Result in these tests sometimes deadlocked during xUnit v3 parallel test runs, probably due to interaction with xUnit synchronization context.
Contributor
Author
|
The deadlock was because of synchronous Task.Wait and Task.Result in some tests. These don't play well with xUnit v3 parallel test runs, probably due to interaction with xUnit synchronization context. ETA: |
Contributor
Author
|
ComponentTests run very slow on MacOS CI leg. 50+ minutes vs 9 minutes on Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some functionality we had with v2 can be restored in the future: