Skip to content

Fix ansible-galaxy collection install check #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthew-on-git merged 1 commit into from
Mar 16, 2026
Merged

Fix ansible-galaxy collection install check #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/install-ansible.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ fi

# Install community.general collection (idempotent)
# Required for yaml callback plugin, json_query filter, and many common modules
if ansible-galaxy collection list community.general &>/dev/null; then
# Note: ansible-galaxy collection list exits 0 even when not installed,
# so we check the output for the collection name instead of the exit code.
if ansible-galaxy collection list community.general 2>/dev/null | grep -q community.general; then
log_info "community.general collection is already installed, skipping"
else
log_info "Installing community.general Ansible collection"
Expand Down
4 changes: 3 additions & 1 deletion tests/test-ansible.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ check_tool "ansible-lint" "--version"
check_tool "molecule" "--version"

# Verify community.general collection is installed
if ansible-galaxy collection list community.general &>/dev/null; then
# Note: ansible-galaxy collection list exits 0 even when not installed,
# so we check the output for the collection name instead of the exit code.
if ansible-galaxy collection list community.general 2>/dev/null | grep -q community.general; then
log_info "community.general collection — OK"
else
log_error "community.general Ansible collection is not installed"
Expand Down
Loading