Skip to content

Fix ansible-galaxy collection install check#14

Merged
matthew-on-git merged 1 commit intomainfrom
fix/ansible-collection-install-check
Mar 16, 2026
Merged

Fix ansible-galaxy collection install check#14
matthew-on-git merged 1 commit intomainfrom
fix/ansible-collection-install-check

Conversation

@matthew-on-git
Copy link
Contributor

@matthew-on-git matthew-on-git commented Mar 16, 2026

Summary

  • ansible-galaxy collection list community.general exits 0 even when the collection is NOT installed
  • The idempotency check always saw "success" and skipped the actual install
  • Fix: pipe output through grep -q community.general to check if the collection actually appears in the list

This is why v1.7.0 shipped without community.general despite PR #13.

Test plan

  • docker build installs community.general successfully
  • ansible-galaxy collection list community.general shows the collection in the new image
  • test-ansible.sh validates the collection is present
  • make check passes

🤖 Generated with Claude Code

@matthew-on-git @claude
fix(ansible): check collection list output instead of exit code
af0e334 
ansible-galaxy collection list exits 0 even when the collection is not
installed, so the idempotency check was always true and the install was
skipped. Check grep output for the collection name instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@matthew-on-git matthew-on-git merged commit 9681964 into main Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@matthew-on-git