Skip to content

#1964: fixed maven using wrong process context #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
laim2003 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

#1964: fixed maven using wrong process context #1967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7451f
#1964: fixed maven using wrong process context
laim2003 May 22, 2026
587b612
#1964: we install maven first and then update the java version.
laim2003 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions cli/src/main/java/com/devonfw/tools/ide/tool/gui/Gui.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,20 @@ protected void doRun() {

ProcessContext processContext = new ProcessContextImpl(this.context);

ToolInstallRequest toolInstallRequest = new ToolInstallRequest(false);
toolInstallRequest.setProcessContext(processContext);
toolInstallRequest.setRequested(
Java java = this.context.getCommandletManager().getCommandlet(Java.class);
Mvn mvn = this.context.getCommandletManager().getCommandlet(Mvn.class);

ToolInstallRequest javaToolInstallRequest = new ToolInstallRequest(false);
javaToolInstallRequest.setProcessContext(processContext);
javaToolInstallRequest.setRequested(
new ToolEditionAndVersion(VersionIdentifier.of("25.*"))
);

Java java = this.context.getCommandletManager().getCommandlet(Java.class);
Mvn mvn = this.context.getCommandletManager().getCommandlet(Mvn.class);
java.install(toolInstallRequest);
mvn.install(false);
ToolInstallRequest mavenToolInstallRequest = new ToolInstallRequest(false);
mavenToolInstallRequest.setProcessContext(processContext);

mvn.install(mavenToolInstallRequest);
java.install(javaToolInstallRequest);
Comment on lines +61 to +62
Copy link
Copy Markdown
Member

@hohwille hohwille May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote in the chat install is wrong since it does the complete installation into the project.
What we really want here is just installTool(...Request).
Maybe the javaToolInstallRequest should have the mavenToolInstallRequest as parent since this is a dependency or maybe thinking even further, we do not need that at all if the dependencies.json will bring that automatically (but I am not sure if we bypass install and just call installTool).


LOG.debug("Starting GUI via commandlet");

Expand Down
Loading