#1964: fixed maven using wrong process context#1967
Draft
laim2003 wants to merge 2 commits into
Draft
Conversation
Collaborator
Coverage Report for CI Build 26280591750Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.05%) to 71.016%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions12 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
reviewed
May 22, 2026
Comment on lines
+61
to
+62
| mvn.install(mavenToolInstallRequest); | ||
| java.install(javaToolInstallRequest); |
Member
There was a problem hiding this comment.
As I wrote in the chat install is wrong since it does the complete installation into the project.
What we really want here is just installTool(...Request).
Maybe the javaToolInstallRequest should have the mavenToolInstallRequest as parent since this is a dependency or maybe thinking even further, we do not need that at all if the dependencies.json will bring that automatically (but I am not sure if we bypass install and just call installTool).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1964
Implemented changes:
Testing instructions
This should now launch the gui without any issues, and maven should use java 25 when initializing.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal