Skip to content

#1761: exclude BETA_OR_BUILD from development phases #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hohwille merged 4 commits into from
Mar 31, 2026
+8 −5
Merged

#1761: exclude BETA_OR_BUILD from development phases #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d25386d
#1761: exclude BETA_OR_BUILD from development phases to support Java …
laert-ll Mar 24, 2026
da59895
extend VersionIdentifierTest to ensure BETA_OR_BUILD is treated as st…
laert-ll Mar 27, 2026
bb5055f
#1761: removed tests regarding isValid() for Java version 8u412b08
laert-ll Mar 31, 2026
e156cf2
#1761: fixed isValid() so that java version 8u412b08 is treated as va…
laert-ll Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cli/src/main/java/com/devonfw/tools/ide/version/VersionPhase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public enum VersionPhase implements AbstractVersionPhase {
UNDEFINED,

/** A revision number (actually not a development phase like {@link #UNDEFINED}). */
REVISION(Boolean.TRUE, "revision", "rev"),
REVISION(Boolean.TRUE, "revision", "rev", "u"),

/** Unstable marker - see {@link VersionSegment#PATTERN_MATCH_ANY_VERSION}. */
UNSTABLE(Boolean.FALSE, "!"),
Expand Down Expand Up @@ -77,7 +77,7 @@ private VersionPhase(Boolean hasNumber, String... ids) {
@Override
public boolean isDevelopmentPhase() {

return (this != UNDEFINED) && (this != NONE) && (this != REVISION) && (this != BUILD);
return (this != UNDEFINED) && (this != NONE) && (this != REVISION) && (this != BUILD) && (this != BETA_OR_BUILD);
}

/**
Expand All @@ -97,7 +97,7 @@ public boolean isDevelopmentPhase() {
*/
public boolean isValid(int number) {

if ((this == UNDEFINED) || (this == BETA_OR_BUILD)) {
if (this == UNDEFINED) {
return false;
}
if (this.hasNumber != null) {
Expand Down
7 changes: 5 additions & 2 deletions cli/src/test/java/com/devonfw/tools/ide/version/VersionIdentifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void testOf() {
*/
@ParameterizedTest
// arrange
@ValueSource(strings = { "1.0", "0.1", "2023.08.001", "2023-06-M1", "11.0.4_11.4", "5.2.23.RELEASE" })
@ValueSource(strings = { "1.0", "0.1", "2023.08.001", "2023-06-M1", "11.0.4_11.4", "5.2.23.RELEASE", "8u412b08" })
void testValid(String version) {

// act
Expand All @@ -78,7 +78,7 @@ void testValid(String version) {
*/
@ParameterizedTest
// arrange
@ValueSource(strings = { "0", "0.0", "1.0.pineapple-pen", "1.0-rc", ".1.0", "1.-0", "RC1", "Beta1", "donut", "8u412b08", "0*.0", "*0", "*.", "17.*alpha",
@ValueSource(strings = { "0", "0.0", "1.0.pineapple-pen", "1.0-rc", ".1.0", "1.-0", "RC1", "Beta1", "donut", "0*.0", "*0", "*.", "17.*alpha",
"17*.1" })
void testInvalid(String version) {

Expand Down Expand Up @@ -193,6 +193,8 @@ void testMatchStable() {
assertThat(pattern.matches(VersionIdentifier.of("17.0.alpha7"))).isFalse();
assertThat(pattern.matches(VersionIdentifier.of("17.0-beta2"))).isFalse();
assertThat(pattern.matches(VersionIdentifier.of("17.0-SNAPSHOT"))).isFalse();
pattern = VersionIdentifier.of("8*");
assertThat(pattern.matches(VersionIdentifier.of("8u412b08"))).isTrue();
}

/**
Expand Down Expand Up @@ -346,6 +348,7 @@ private static void assertIncrementLastDigit(String version, boolean keepLetters
void testIsStable() {

assertThat(VersionIdentifier.of("2025.01.002").isStable()).isTrue();
assertThat(VersionIdentifier.of("8u412b08").isStable()).isTrue();
assertThat(VersionIdentifier.of("1.0-rc1").isStable()).isFalse();
assertThat(VersionIdentifier.of("1.0-alpha1.rc2").isStable()).isFalse();
assertThat(VersionIdentifier.LATEST.isStable()).isTrue();
Expand Down
Loading