Skip to content

#1761: exclude BETA_OR_BUILD from development phases#1776

Open
laert-ll wants to merge 2 commits intodevonfw:mainfrom
laert-ll:bug/1761-install-version-pattern-not-working
Open

#1761: exclude BETA_OR_BUILD from development phases#1776
laert-ll wants to merge 2 commits intodevonfw:mainfrom
laert-ll:bug/1761-install-version-pattern-not-working

Conversation

@laert-ll
Copy link
Contributor

This PR fixes #1761

Implemented changes:

  • Excluded BETA_OR_BUILD from development phases to ensure legacy Java 8 version patterns are correctly recognized as stable during installation.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions

@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Mar 26, 2026
@laert-ll laert-ll self-assigned this Mar 26, 2026
@laert-ll laert-ll requested a review from hohwille March 26, 2026 10:52
@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2026

Pull Request Test Coverage Report for Build 23643547060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 70.433%

Totals Coverage Status
Change from base Build 23641462284: 0.03%
Covered Lines: 10800
Relevant Lines: 14726

💛 - Coveralls

@laert-ll laert-ll moved this from 🆕 New to Team Review in IDEasy board Mar 26, 2026
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laert-ll thanks for your PR and fix. Great finding. 👍
Could you also extend VersionIdentifierTest so we actually cover the bug and specify in the test what we actually expect to happen (and prevent that it may break again in the future).
Please also add the issue to our CHANGELOG (see DoD).

@github-project-automation github-project-automation bot moved this from Team Review to 👀 In review in IDEasy board Mar 27, 2026
@laert-ll laert-ll force-pushed the bug/1761-install-version-pattern-not-working branch from a725879 to 1a11b26 Compare March 27, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Install version pattern not working

3 participants