Skip to content

chore: Part 1 of adding type validation to tests - type checking test/core/pipeline/ folder #10409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjrl merged 7 commits into from
Jan 22, 2026
Merged

chore: Part 1 of adding type validation to tests - type checking test/core/pipeline/ folder #10409

sjrl merged 7 commits into from
Jan 22, 2026
+170 −131

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 20, 2026

Related Issues

Proposed Changes:

Add type checking to the test/core/pipeline/ folder.

How did you test it?

Running typing tests on the newly added folder.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl sjrl requested a review from a team as a code owner January 20, 2026 14:32
@sjrl sjrl requested review from anakin87 and removed request for a team January 20, 2026 14:32
@vercel
Copy link

vercel bot commented Jan 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
haystack-docs Ignored Ignored Preview Jan 22, 2026 0:18am

Request Review

@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jan 20, 2026
@sjrl sjrl self-assigned this Jan 20, 2026
sjrl
sjrl commented Jan 20, 2026
View reviewed changes
haystack/core/component/types.py

name: str
type: type
type: type | UnionType
Copy link
Contributor Author

@sjrl sjrl Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change needed outside of test folder. Without this then passing something like type=int | str would cause mypy to throw an error.

@anakin87
Copy link
Member

anakin87 commented Jan 20, 2026

I see there's a type error.

(Over time, let's also check if mypy running time increases significantly)

@sjrl
Copy link
Contributor Author

sjrl commented Jan 20, 2026

I see there's a type error.

(Over time, let's also check if mypy running time increases significantly)

@anakin87 I'll need to investigate this more about how we can properly support this. I'm not too familiar with how python treats type but it looks like UnionType doesn't count as a type which cascades down into more issues in our type_util methods. I'll see if there is a reasonable way to get it working short of setting type: Any

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jan 22, 2026
@sjrl
Copy link
Contributor Author

sjrl commented Jan 22, 2026

@anakin87 I resolved the typing issues so this should be good to go now!

anakin87
anakin87 approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (Sorry for the conflicts)

@sjrl sjrl enabled auto-merge (squash) January 22, 2026 12:18
@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2026

Pull Request Test Coverage Report for Build 21248149201

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 92.341%
Files with Coverage Reduction New Missed Lines %
core/component/types.py 1 91.89%
Totals Coverage Status
Change from base Build 21247144614: 0.0%
Covered Lines: 14710
Relevant Lines: 15930
💛 - Coveralls

@sjrl sjrl merged commit b375063 into main Jan 22, 2026
20 checks passed
@sjrl sjrl deleted the start-typing-tests branch January 22, 2026 12:29
@sjrl sjrl mentioned this pull request Jan 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees

@sjrl sjrl

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:core topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjrl @anakin87 @coveralls