Skip to content

chore: Part 2 type checking tests/core folder #10428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjrl merged 9 commits into from
Jan 22, 2026
Merged

chore: Part 2 type checking tests/core folder #10428

sjrl merged 9 commits into from
Jan 22, 2026
+162 −125

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 22, 2026

Related Issues

Proposed Changes:

Follow up to #10409

How did you test it?

Running type tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl sjrl requested a review from a team as a code owner January 22, 2026 13:44
@sjrl sjrl requested review from anakin87 and removed request for a team January 22, 2026 13:44
@vercel
Copy link

vercel bot commented Jan 22, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
haystack-docs Ignored Ignored Preview Jan 22, 2026 1:51pm

Request Review

@sjrl sjrl self-assigned this Jan 22, 2026
@sjrl sjrl added ignore-for-release-notes PRs with this flag won't be included in the release notes. and removed topic:tests topic:build/distribution topic:core labels Jan 22, 2026
@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2026

Pull Request Test Coverage Report for Build 21250986907

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 92.341%
Files with Coverage Reduction New Missed Lines %
core/super_component/utils.py 4 95.79%
core/component/sockets.py 5 85.37%
Totals Coverage Status
Change from base Build 21248482406: 0.0%
Covered Lines: 14710
Relevant Lines: 15930
💛 - Coveralls

anakin87
anakin87 approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjrl sjrl merged commit ffb81be into main Jan 22, 2026
20 checks passed
@sjrl sjrl deleted the part-2-typing-tests branch January 22, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees

@sjrl sjrl

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:core topic:tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjrl @coveralls @anakin87